remove point and version for accessibility #8
Conversation
That's precisely why I asked the separate pull request :) Please make it so we can discuss about it there. |
| @@ -711,7 +711,7 @@ void view_screen (misc_t *misc, daisy_t *daisy) | |||
| if (l / 2 * 2 == l) | |||
| waddstr (misc->screenwin, " "); | |||
| for (x = l; x < 56; x += 2) | |||
| waddstr (misc->screenwin, " ."); | |||
| waddstr (misc->screenwin, " "); | |||
There was a problem hiding this comment.
if we are going to display only spaces, please replace this 2-by-2 loop and the previous if with a single 1-by-1 loop.
I wonder what people think about it: are these periods useful? It's clearly a burden for Orca so it's probably worth dropping them, I wonder if they have some use (except for sighted users for whom they may be convenient to track lines, but not sure if it's really that useful?) |
|
Yes this is a problem for Orca, and not very useful for visually impaired users. If you are unsure, you can add a command line option to not put them. |
I put this here but I can't see how to do the pull request to put this. |
|
You can create another branch in your repository, to create another pull request from that |
Hi @sthibaul
The Pull Request for this ticket #7 for only this points :
For this point :
I can make this modification, but there is an impact because future users will not be able to see certain files in ebook-speaker's file explorer.